Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Silence-Android Silence-Android
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 287
    • Issues 287
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SilenceSilence
  • Silence-AndroidSilence-Android
  • Merge requests
  • !675

Fix encoding of plaintext backups

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Bastien Le Querrec requested to merge github/fork/whiver/patch/xml_encoding into unstable Mar 31, 2018
  • Overview 0
  • Commits 17
  • Pipelines 0
  • Changes 65

Created by: whiver

Fixes #659 : Rewrite special characters escaping in plaintext backups to avoid having some characters illegally escaped (such as surrogates characters). This PR uses Apache Commons's XML escaping method instead, which correctly handles character encoding, so the part using regex to match characters that needed to be encoded has been removed.

Also force UTF-8 encoding of output file to match the charset specified in it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/whiver/patch/xml_encoding