Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Silence-Android Silence-Android
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 287
    • Issues 287
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SilenceSilence
  • Silence-AndroidSilence-Android
  • Merge requests
  • !664

Project improvements : proposals from Android Studio

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Bastien Le Querrec requested to merge github/fork/wdesportes/ameliorations-silence into unstable Mar 01, 2018
  • Overview 7
  • Commits 48
  • Pipelines 0
  • Changes 116

Created by: williamdes

I applied some of the propositions that Android Studio inspector found in Silence. I let you cherry-pick the commits that you want.

For me the more usefull commits are :

  • "SDK_INT is never <9 because minSdkVersion 9"
  • "Removed unused import statements"
  • "[Manual] Missing supercall fix "

I will push more commits on this PR soon.

I hope @BLeQuerrec that you will accept some of the proposals from Android Studio. Let me know what you think about all that.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/wdesportes/ameliorations-silence