From ef124884a4bf154a22b83896d0cd53dc8340bc45 Mon Sep 17 00:00:00 2001
From: EBendinelli <eliot.bendinelli@gmail.com>
Date: Tue, 9 Jan 2018 16:25:25 +0100
Subject: [PATCH] Adding an option to disable the new message separator in
 conversation. Close #559

---
 res/values/strings.xml                                   | 2 ++
 res/xml/preferences_sms_mms.xml                          | 6 ++++++
 src/org/smssecure/smssecure/ConversationFragment.java    | 9 +++++++--
 src/org/smssecure/smssecure/util/SilencePreferences.java | 5 +++++
 4 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/res/values/strings.xml b/res/values/strings.xml
index 908257b7..848e993e 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -752,6 +752,8 @@
     <string name="preferences_notifications__display_in_notifications">Display in notifications</string>
     <string name="preferences__show_sent_time">Show sent time</string>
     <string name="preferences__show_sent_time_instead_of_received_time_in_conversations">Show sent time instead of received time for incoming messages</string>
+    <string name="preferences__hide_unread_message_divider">Hide unread message divider</string>
+    <string name="preferences__hide_unread_message_divider_in_conversation">Hide the unread message divider in conversation</string>
     <string name="preferences_chats__mms">MMS</string>
     <string name="preferences__auto_retrieve">Auto-retrieve</string>
     <string name="preferences__automatically_retrieve_mms_messages">Automatically retrieve MMS messages</string>
diff --git a/res/xml/preferences_sms_mms.xml b/res/xml/preferences_sms_mms.xml
index 1fa83d8c..b347971e 100644
--- a/res/xml/preferences_sms_mms.xml
+++ b/res/xml/preferences_sms_mms.xml
@@ -23,6 +23,12 @@
                         android:summary="@string/preferences__show_sent_time_instead_of_received_time_in_conversations"
                         android:defaultValue="false" />
 
+    <org.smssecure.smssecure.components.SwitchPreferenceCompat
+        android:key="pref_hide_unread_message_divider"
+        android:title="@string/preferences__hide_unread_message_divider"
+        android:summary="@string/preferences__hide_unread_message_divider_in_conversation"
+        android:defaultValue="false" />
+
     <org.smssecure.smssecure.components.SwitchPreferenceCompat
                         android:defaultValue="false"
                         android:key="pref_delivery_report_sms"
diff --git a/src/org/smssecure/smssecure/ConversationFragment.java b/src/org/smssecure/smssecure/ConversationFragment.java
index 89d3a287..209af48e 100644
--- a/src/org/smssecure/smssecure/ConversationFragment.java
+++ b/src/org/smssecure/smssecure/ConversationFragment.java
@@ -63,11 +63,13 @@ import org.smssecure.smssecure.mms.Slide;
 import org.smssecure.smssecure.recipients.RecipientFactory;
 import org.smssecure.smssecure.recipients.Recipients;
 import org.smssecure.smssecure.sms.MessageSender;
+import org.smssecure.smssecure.util.SilencePreferences;
 import org.smssecure.smssecure.util.task.ProgressDialogAsyncTask;
 import org.smssecure.smssecure.util.SaveAttachmentTask;
 import org.smssecure.smssecure.util.SaveAttachmentTask.Attachment;
 import org.smssecure.smssecure.util.StickyHeaderDecoration;
 import org.smssecure.smssecure.util.ViewUtil;
+import org.smssecure.smssecure.util.SilencePreferences;
 
 import java.util.Collections;
 import java.util.Comparator;
@@ -259,8 +261,11 @@ public class ConversationFragment extends Fragment
       list.removeItemDecoration(lastSeenDecoration);
     }
 
-    lastSeenDecoration = new ConversationAdapter.LastSeenHeader(getListAdapter(), lastSeen);
-    list.addItemDecoration(lastSeenDecoration);
+    final Context context = getActivity().getApplicationContext();
+    if(!SilencePreferences.hideUnreadMessageDivider(context)){
+      lastSeenDecoration = new ConversationAdapter.LastSeenHeader(getListAdapter(), lastSeen);
+      list.addItemDecoration(lastSeenDecoration);
+    }
   }
 
   private void handleCopyMessage(final Set<MessageRecord> messageRecords) {
diff --git a/src/org/smssecure/smssecure/util/SilencePreferences.java b/src/org/smssecure/smssecure/util/SilencePreferences.java
index 39d79f0a..6ccf2e2b 100644
--- a/src/org/smssecure/smssecure/util/SilencePreferences.java
+++ b/src/org/smssecure/smssecure/util/SilencePreferences.java
@@ -74,6 +74,7 @@ public class SilencePreferences {
   public  static final String REPEAT_ALERTS_PREF               = "pref_repeat_alerts";
   private static final String DISABLE_EMOJI_DRAWER             = "pref_disable_emoji_drawer";
   private static final String SHOW_SENT_TIME                   = "pref_show_sent_time";
+  private static final String HIDE_UNREAD_MESSAGE_DIVIDER      = "pref_hide_unread_message_divider";
 
   private static final String LOCAL_REGISTRATION_ID_PREF       = "pref_local_registration_id";
   private static final String FALLBACK_SMS_ALLOWED_PREF        = "pref_allow_sms_traffic_out";
@@ -559,6 +560,10 @@ public class SilencePreferences {
     return getBooleanPreference(context, SHOW_SENT_TIME, false);
   }
 
+  public static boolean hideUnreadMessageDivider(Context context) {
+    return getBooleanPreference(context, HIDE_UNREAD_MESSAGE_DIVIDER, false);
+  }
+
   public static int getLastAppSubscriptionId(Context context) {
     return getIntegerPreference(context, LAST_APP_SUBSCRIPTION_ID_PREF, 0);
   }
-- 
GitLab