Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Silence-Android Silence-Android
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 287
    • Issues 287
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SilenceSilence
  • Silence-AndroidSilence-Android
  • Merge requests
  • !529

Unbreak dual sim support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bastien Le Querrec requested to merge dual-sim into unstable Feb 06, 2017
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 49

Description

This PR fixes dual SIM support.

  • Fixes issue when sending encrypted message with ICCs in slot >=2
  • Send keys from all ICCs
  • Use one private/public key per SIM card (otherwise users will get "Bad encrypted" errors)
  • Fix session termination
  • Upgrade database (now, sessions are stored in files that depend on subscription ID)
  • Display all identities in VerifyIdentityActivity
  • Generate keys when a new SIM card is inserted
  • Match ICC<-->keys
  • Select SIM according to last received message
  • Display slot index or number if 2+ ICC use the same display name
  • Select ICCs eligible for auto key exchange
  • Ask user to select a SIM if no one is selected by default (selecting a default subscription for SMS messages is mandatory in Android)
  • Test with Android 5.1.1+ on one-ICC devices
  • Test with Android <5.1.1

Closes #517 Fixes #467 (closed) Fixes #497 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dual-sim